and though bugs are the bane of my existence, rest assured the wretched thing will get the best of care here

This project is mirrored from https://github.com/openssl/openssl.git. Pull mirroring failed .
Last successful update .
  1. 28 Jan, 2021 4 commits
  2. 27 Jan, 2021 3 commits
  3. 26 Jan, 2021 16 commits
  4. 25 Jan, 2021 4 commits
  5. 23 Jan, 2021 6 commits
  6. 22 Jan, 2021 3 commits
    • Matt Caswell's avatar
      8a9394c1
    • Matt Caswell's avatar
      Don't copy parameters on setting a key in libssl · fc52ae8c
      Matt Caswell authored
      Whenever we set a private key in libssl, we first found the certificate
      that matched the key algorithm. Then we copied the key parameters from the
      private key into the public key for the certficate before finally checking
      that the private key matched the public key in the certificate. This makes
      no sense! Part of checking the private key is to make sure that the
      parameters match. It seems that this code has been present since SSLeay.
      Perhaps at some point it made sense to do this - but it doesn't any more.
      
      We remove that piece of code altogether. The previous code also had the
      undocumented side effect of removing the certificate if the key didn't
      match. This makes sense if you've just overwritten the parameters in the
      certificate with bad values - but doesn't seem to otherwise. I've also
      removed that error logic.
      
      Due to issue #13893, the public key associated with the certificate is
      always a legacy key. EVP_PKEY_copy_parameters will downgrade the "from"
      key to legacy if the target is legacy, so this means that in libssl all
      private keys were always downgraded to legacy when they are first set
      in the SSL/SSL_CTX. Removing the EVP_PKEY_copy_parameters code has the
      added benefit of removing that downgrade.
      Reviewed-by: default avatarTomas Mraz <tomas@openssl.org>
      (Merged from https://github.com/openssl/openssl/pull/13899)
      fc52ae8c
    • Matt Caswell's avatar
      Ensure legacy_asn1_ctrl_to_param can handle MDs not in the OBJ database · 5060cd5f
      Matt Caswell authored
      The legacy_asn1_ctrl_to_param implementation of
      ASN1_PKEY_CTRL_DEFAULT_MD_NID calls EVP_PKEY_get_default_digest_name()
      which returns an mdname. Previously we were using OBJ_sn2nid/OBJ_ln2nid
      to lookup that name in the OBJ database. However we might get an md name
      back that only exists in the namemap, not in the OBJ database. In that
      case we need to check the various aliases for the name, to see if one of
      those matches the name we are looking for.
      Reviewed-by: default avatarTomas Mraz <tomas@openssl.org>
      (Merged from https://github.com/openssl/openssl/pull/13899)
      5060cd5f
  7. 21 Jan, 2021 4 commits