and though bugs are the bane of my existence, rest assured the wretched thing will get the best of care here

  1. 30 Mar, 2016 1 commit
    • Andre Simoes Dias Vieira's avatar
      Fix using uninitialised values · 439ccc8b
      Andre Simoes Dias Vieira authored
      We did a code refacotr here
      https://sourceware.org/ml/gdb-patches/2013-11/msg00063.html
      
      >	(get_current_thread): New function, factored out from ...
      >	(add_current_inferior_and_thread): ... this.  Adjust.
      >
      >@@ -3332,18 +3371,8 @@ add_current_inferior_and_thread (char *wait_status)
      >
      >   inferior_ptid = null_ptid;
      >
      >-  /* Now, if we have thread information, update inferior_ptid.  First
      >-     if we have a stop reply handy, maybe it's a T stop reply with a
      >-     "thread" register we can extract the current thread from.  If
      >-     not, ask the remote which is the current thread, with qC.  The
      >-     former method avoids a roundtrip.  Note we don't use
      >-     remote_parse_stop_reply as that makes use of the target
      >-     architecture, which we haven't yet fully determined at this
      >-     point.  */
      >-  if (wait_status != NULL)
      >-    ptid = stop_reply_extract_thread (wait_status);
      >-  if (ptid_equal (ptid, null_ptid))
      >-    ptid = remote_current_thread (inferior_ptid);
      >+  /* Now, if we have thread information, update inferior_ptid.  */
      >+  ptid = get_current_thread (wait_status);
      
      but after the refactor, local variable ptid is used without
      initialisation.  However, before this change, ptid is initialised to
      null_ptid.  This error can be found by valgrind too...
      
      ==3298==    at 0x6B99BA: ptid_equal (ptid.c:80)
      ==3298==    by 0x4C67FF: get_current_thread (remote.c:3484)
      ==3298==    by 0x4C6951: add_current_inferior_and_thread (remote.c:3511)
      ==3298==    by 0x4C762C: extended_remote_create_inferior (remote.c:8506)
      ==3298==    by 0x5A5312: run_command_1 (infcmd.c:606)
      ==3298==    by 0x68B4FB: execute_command (top.c:463)
      ==3298==    by 0x5C7214: command_handler (event-top.c:494)
      ==3298==    by 0x5C78A3: command_line_handler (event-top.c:692)
      ==3298==    by 0x6DEB57: rl_callback_read_char (callback.c:220)
      ==3298==    by 0x5C7278: rl_callback_read_char_wrapper (event-top.c:171)
      ==3298==    by 0x5C72C2: stdin_event_handler (event-top.c:432)
      ==3298==    by 0x5C6194: gdb_wait_for_event (event-loop.c:834)
      
      This patch initialises local variable ptid to null in get_current_thread.
      We don't need to initialise ptid in add_current_inferior_and_thread,
      so this patch also removes the ptid initialisation.
      
      gdb/ChangeLog.arm:
      2016-03-29  Andre Vieira <andre.simoesdiasvieira@arm.com>
        Backport from mainline
        2015-07-17  Yao Qi  <yao.qi@linaro.org>
      
        * remote.c (get_current_thread): Initialise ptid to null_ptid.
        (add_current_inferior_and_thread): Don't initialise ptid.
      439ccc8b
  2. 01 Mar, 2016 1 commit
    • Andre Simoes Dias Vieira's avatar
      Fix for GDB crashing with printf on ARM targets. · 24ad6cef
      Andre Simoes Dias Vieira authored
      gdb/ChangeLog.arm:
      2016-02-16  Andre Vieira  <andre.simoesdiasvieira@arm.com>
          Backport from mainline
          2016-02-04  Yao Qi  <yao.qi@linaro.org>
      
      	* remote.c (remote_wait_as): Set rs->waiting_for_stop_reply to
      	0 before handling 'F' and set it back afterwards.
      24ad6cef
  3. 10 Feb, 2016 2 commits
    • Don Breazeal's avatar
      Fix '-data-read-memory-bytes' typo/assertion · 718b36fe
      Don Breazeal authored
      Backported to the 7.10 branch per this thread:
      https://www.sourceware.org/ml/gdb-patches/2016-02/msg00134.html
      
      This patch fixes a typo in target.c:read_memory_robust, where
      it calls read_whatever_is_readable with the function arguments
      in the wrong order.  Depending on the address being read, it
      can cause an xmalloc with a huge size, resulting in an assertion
      failure, or just read something other than what was requested.
      
      The problem only arises when GDB is handling an MI
      "-data-read-memory-bytes" request and the initial target_read returns
      an error status.  Note that read_memory_robust is only called from
      the MI code.
      
      gdb/ChangeLog:
      
      	* gdb/target.c (read_memory_robust): Call
      	read_whatever_is_readable with arguments in the correct order.
      718b36fe
    • GDB Administrator's avatar
      Automatic date update in version.in · 9939a5ae
      GDB Administrator authored
      9939a5ae
  4. 09 Feb, 2016 1 commit
  5. 08 Feb, 2016 1 commit
  6. 07 Feb, 2016 1 commit
  7. 06 Feb, 2016 1 commit
  8. 05 Feb, 2016 1 commit
  9. 04 Feb, 2016 1 commit
  10. 03 Feb, 2016 1 commit
  11. 02 Feb, 2016 1 commit
  12. 01 Feb, 2016 1 commit
  13. 31 Jan, 2016 1 commit
  14. 30 Jan, 2016 1 commit
  15. 29 Jan, 2016 1 commit
  16. 28 Jan, 2016 1 commit
  17. 27 Jan, 2016 1 commit
  18. 26 Jan, 2016 1 commit
  19. 25 Jan, 2016 1 commit
  20. 24 Jan, 2016 1 commit
  21. 23 Jan, 2016 1 commit
  22. 22 Jan, 2016 1 commit
  23. 21 Jan, 2016 1 commit
  24. 20 Jan, 2016 1 commit
  25. 19 Jan, 2016 1 commit
  26. 18 Jan, 2016 1 commit
  27. 17 Jan, 2016 1 commit
  28. 16 Jan, 2016 1 commit
  29. 15 Jan, 2016 1 commit
  30. 14 Jan, 2016 1 commit
  31. 13 Jan, 2016 1 commit
  32. 12 Jan, 2016 1 commit
  33. 11 Jan, 2016 1 commit
  34. 10 Jan, 2016 1 commit
  35. 09 Jan, 2016 1 commit
  36. 08 Jan, 2016 1 commit
  37. 07 Jan, 2016 1 commit
  38. 06 Jan, 2016 1 commit
  39. 05 Jan, 2016 1 commit