and though bugs are the bane of my existence, rest assured the wretched thing will get the best of care here

  1. 26 Apr, 2013 3 commits
  2. 25 Apr, 2013 6 commits
    • Sergio Durigan Junior's avatar
      Andrew Haley found a bug on GDB running on ARM when using · bf057a8f
      Sergio Durigan Junior authored
      --enable-64-bit-bfd.  Basically the issue happens when dealing with "bl"
      instructions: GDB does branch destination calculation and (wrongly)
      sign-extends the PC.  Here is a piece of his original message explaining
      the problem:
      
      >      next_pc = arm_get_next_pc (frame, get_frame_pc (frame));
      >
      >      /* The Linux kernel offers some user-mode helpers in a high page.  We can
      >         not read this page (as of 2.6.23), and even if we could then we couldn't
      >         set breakpoints in it, and even if we could then the atomic operations
      >         would fail when interrupted.  They are all called as functions and return
      >         to the address in LR, so step to there instead.  */
      >      if (next_pc > 0xffff0000)
      >        next_pc = get_frame_register_unsigned (frame, ARM_LR_REGNUM);
      >
      >      arm_insert_single_step_breakpoint (gdbarch, aspace, next_pc);
      >
      >    Unfortunately, branch destination addresses are SIGN EXTENDED to 64
      >    bits.  So,
      >
      >    (top-gdb) p/x next_pc
      >    $14 = 0xffffffffb6df2864
      >
      >    Which triggers the next_pc = get_frame_register_unsigned(), and we
      >    cannot step into any branches because the destination PC is wrong.
      
      Anyway, the fix is simple and Andrew himself provided it for us.  It
      took a while for me to figure out how to trigger the bug (in order to
      write a testcase for it), but I finally made it.
      
      The attached patch fixes the problem (by casting to `unsigned long'
      instead of just `long'), and also includes a testcase to reproduce the
      issue.
      
      gdb/ChangeLog:
      
      2013-04-25  Andrew Haley  <aph@redhat.com>
      
      	* arm-tdep.c (BranchDest): Cast result as "unsigned long",
      	instead of "long".
      
      gdb/testsuite/ChangeLog:
      
      2013-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
      
      	* gdb.arch/arm-bl-branch-dest.c: New file.
      	* gdb.arch/arm-bl-branch-dest.exp: Likewise.
      bf057a8f
    • Hui Zhu's avatar
      2013-04-25 Hui Zhu <hui@codesourcery.com> · f9658b63
      Hui Zhu authored
      	* breakpoint.c (build_target_command_list): Change loc->cond_bytecode
      	to loc->cmd_bytecode.
      f9658b63
    • Hui Zhu's avatar
      2013-04-25 Hui Zhu <hui@codesourcery.com> · c6f3d018
      Hui Zhu authored
      	PR gdb/15186
      	* ax.c (ax_printf): Add fflush.
      c6f3d018
    • Hui Zhu's avatar
      Fix format error of ChangeLog. · d0d69991
      Hui Zhu authored
      d0d69991
    • Hui Zhu's avatar
      2013-04-25 Hui Zhu <hui@codesourcery.com> · fdc69460
      Hui Zhu authored
      	PR gdb/15293
      
      	* breakpoint.c (bpstat_what): Add BPSTAT_WHAT_SINGLE to bp_dprintf.
      
      2013-04-25  Hui Zhu  <hui@codesourcery.com>
      
      	PR gdb/15293
      
      	* gdb.base/dprintf.exp: Add ignore command.
      fdc69460
    • gdbadmin's avatar
      *** empty log message *** · 72b8ad07
      gdbadmin authored
      72b8ad07
  3. 24 Apr, 2013 2 commits
    • Hui Zhu's avatar
      2013-04-24 Hui Zhu <hui@codesourcery.com> · f9c9d21f
      Hui Zhu authored
      	PR gdb/15165
      
      	* breakpoint.c (dprintf_print_recreate): New.
      	(save_breakpoints): Let it not save dprintf commands.
      	(initialize_breakpoint_ops): Set dprintf_print_recreate.
      
      2013-04-24  Hui Zhu  <hui@codesourcery.com>
      
      	PR gdb/15165
      
      	* gdb.base/save-bp.exp: Add test for dprintf.
      f9c9d21f
    • gdbadmin's avatar
      *** empty log message *** · c3cb4b0c
      gdbadmin authored
      c3cb4b0c
  4. 23 Apr, 2013 1 commit
  5. 22 Apr, 2013 1 commit
  6. 21 Apr, 2013 1 commit
  7. 20 Apr, 2013 1 commit
  8. 19 Apr, 2013 2 commits
    • Pedro Alves's avatar
      Fix the x87 FP register printout when issuing the “info float” command. · 3832c7a3
      Pedro Alves authored
      Consider the following simple program:
      
      .globl  _start
      .text
      _start:
            fldt    val
      .data
            val: .byte 0x00,0x00,0x45,0x07,0x11,0x19,0x22,0xe9,0xfe,0xbf
      
      With current GDB on x86-64 GNU/Linux hosts, after the moment the fldt
      command has been executed the register st(0) looks like this,
      according to the “info regs” output (TOP=7):
      
        R7: Valid   0xffffffbffffffffeffffffe922191107450000 -0.910676542908976927
      
      which is clearly wrong (just count its length).  The problem is due to
      the printf statement (see patch) printing a promoted integer value of
      a char argument "raw[i]", and, since char is signed on x86-64
      GNU/Linux, the erroneous “ffffff” are printed for the first three
      bytes which turn out to be "negative".  The fix is to use gdb_byte
      instead which is unsigned (and is the type of value_contents(), the
      type to be used for raw target bytes anyway).  After the fix the value
      will be printed correctly:
      
        R7: Valid   0xbffee922191107450000 -0.910676542908976927
      
      gdb/
      2013-04-19  Vladimir Kargov <kargov@gmail.com>
      	    Pedro Alves  <palves@redhat.com>
      
      	* i387-tdep.c (i387_print_float_info): Use gdb_byte for pointer to
      	value contents.
      
      gdb/testsuite/
      2013-04-19  Vladimir Kargov  <kargov@gmail.com>
      	    Pedro Alves  <palves@redhat.com>
      
      	* gdb.arch/i386-float.S: New file.
      	* gdb.arch/i386-float.exp: New file.
      3832c7a3
    • gdbadmin's avatar
      *** empty log message *** · 396a672d
      gdbadmin authored
      396a672d
  9. 18 Apr, 2013 1 commit
  10. 17 Apr, 2013 1 commit
  11. 16 Apr, 2013 1 commit
  12. 15 Apr, 2013 1 commit
  13. 14 Apr, 2013 1 commit
  14. 13 Apr, 2013 1 commit
  15. 12 Apr, 2013 4 commits
    • Jan Kratochvil's avatar
      gdb/doc/ · c79b2af3
      Jan Kratochvil authored
      	* gdb.texinfo (Auto-loading safe path): Add quick -iex using command
      	line below the sample output.
      c79b2af3
    • Jan Kratochvil's avatar
      gdb/ · b7c3ddd4
      Jan Kratochvil authored
      	Fix GDB regression related to PR binutils/14813.
      	* jit.c (mem_bfd_iovec_close): Return 0 for success.
      	* minidebug.c (lzma_close): Add return value comment.
      	* remote.c (remote_bfd_iovec_close): Return 0 for success.
      	* solib-spu.c (spu_bfd_iovec_close): Likewise.
      	* spu-linux-nat.c (spu_bfd_iovec_close): Likewise.
      b7c3ddd4
    • Hui Zhu's avatar
      2013-04-12 Pedro Alves <palves@redhat.com> · a666b8f7
      Hui Zhu authored
      	    Hui Zhu  <hui@codesourcery.com>
      
      	* breakpoint.c (dprintf_re_set): New.
      	(initialize_breakpoint_ops): Set dprintf_breakpoint_ops re_set
      	to dprintf_re_set.
      
      2013-04-12  Hui Zhu  <hui@codesourcery.com>
      
      	* gdb.base/Makefile.in (EXECUTABLES): Add dprintf-pending.
      	(MISCELLANEOUS): Add dprintf-pendshr.sl.
      	* gdb.base/dprintf-pending.c, gdb.base/dprintf-pending.exp: New.
      a666b8f7
    • gdbadmin's avatar
      *** empty log message *** · 977a9534
      gdbadmin authored
      977a9534
  16. 11 Apr, 2013 2 commits
  17. 10 Apr, 2013 1 commit
  18. 09 Apr, 2013 3 commits
  19. 08 Apr, 2013 1 commit
  20. 07 Apr, 2013 1 commit
  21. 06 Apr, 2013 3 commits
    • Eli Zaretskii's avatar
      Fix date of last entry. · e3fbbc56
      Eli Zaretskii authored
      e3fbbc56
    • Eli Zaretskii's avatar
      Fix GDB relocation on MinGW. · 62257b76
      Eli Zaretskii authored
      	* mingw-hdep.c (windows_get_absolute_argv0): New function.
      	Include main.h.
      
      	* main.h (windows_get_absolute_argv0): Add prototype.
      
      	* main.c (get_init_files): Use filename_ncmp instead of strncmp.
      	Use IS_DIR_SEPARATOR instead of looking for a character inside
      	SLASH_STRING.  Include filenames.h.
      	(captured_main) [__MINGW32__]: Make argv[0] absolute, so that
      	relocate_gdb_directory works when passed gdb_program_name.
      62257b76
    • gdbadmin's avatar
      *** empty log message *** · 2fe1d6ad
      gdbadmin authored
      2fe1d6ad
  22. 05 Apr, 2013 2 commits
    • Jan Kratochvil's avatar
      gdb/ · df1e06d8
      Jan Kratochvil authored
      	Fix compatibility with Linux kernel 3.8.3.
      	* linux-tdep.c (linux_find_memory_regions_full): Move variable number
      	to more inner block.  Remove parsing of NUMBER from outer block.
      	Parse NUMBER only if KEYWORD has been identified.
      df1e06d8
    • Jan Kratochvil's avatar
      gdb/ · 5bbce163
      Jan Kratochvil authored
      	Fix variable name shadowing.
      	* linux-tdep.c (linux_find_memory_regions_full): Rename outer variable
      	filename to mapsfilename and update its uses.
      5bbce163