and though bugs are the bane of my existence, rest assured the wretched thing will get the best of care here

  1. 23 Jan, 2019 5 commits
    • Hans Wennborg's avatar
      Merging r351670: · 17c9824f
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351670 | ericwf | 2019-01-20 02:21:35 +0100 (Sun, 20 Jan 2019) | 7 lines
      
      Fix aligned allocation availability XFAILs after D56445.
      
      D56445 bumped the minimum Mac OS X version required for aligned
      allocation from 10.13 to 10.14. This caused libc++ tests depending
      on the old value to break.
      
      This patch updates the XFAILs for those tests to include 10.13.
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351980
      17c9824f
    • Hans Wennborg's avatar
      Merging r351899: · b00b2b84
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351899 | pcc | 2019-01-23 00:54:49 +0100 (Wed, 23 Jan 2019) | 26 lines
      
      COFF, ELF: ICF: Perform 2 rounds of relocation hash propagation.
      
      LLD's performance on PGO instrumented Windows binaries was still not
      great even with the fix in D56955; out of the 2m41s linker runtime,
      around 2 minutes were still being spent in ICF. I looked into this more
      closely and discovered that the vast majority of the runtime was being
      spent segregating .pdata sections with the following relocation chain:
      
      .pdata -> identical .text -> unique PGO counter (not eligible for ICF)
      
      This patch causes us to perform 2 rounds of relocation hash
      propagation, which allows the hash for the .pdata sections to
      incorporate the identifier from the PGO counter. With that, the amount
      of time spent in ICF was reduced to about 2 seconds. I also found that
      the same change led to a significant ICF performance improvement in a
      regular release build of Chromium's chrome_child.dll, where ICF time
      was reduced from around 1s to around 700ms.
      
      With the same change applied to the ELF linker, median of 100 runs
      for lld-speed-test/chrome reduced from 4.53s to 4.45s on my machine.
      
      I also experimented with increasing the number of propagation rounds
      further, but I did not observe any further significant performance
      improvements linking Chromium or Firefox.
      
      Differential Revision: https://reviews.llvm.org/D56986
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351964
      b00b2b84
    • Hans Wennborg's avatar
      Merging r351898: · 40cbc004
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351898 | pcc | 2019-01-23 00:51:35 +0100 (Wed, 23 Jan 2019) | 13 lines
      
      COFF, ELF: Adjust ICF hash computation to account for self relocations.
      
      It turns out that sections in PGO instrumented object files on Windows
      contain a large number of relocations pointing to themselves. With
      r347429 this can cause many sections to receive the same hash (usually
      zero) as a result of a section's hash being xor'ed with itself.
      
      This patch causes the COFF and ELF linkers to avoid this problem
      by adding the hash of the relocated section instead of xor'ing it.
      On my machine this causes the regressing test case
      provided by Mozilla to terminate in 2m41s.
      
      Differential Revision: https://reviews.llvm.org/D56955
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351963
      40cbc004
    • Hans Wennborg's avatar
      Merging r351738: · f669262c
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351738 | kadircet | 2019-01-21 11:10:18 +0100 (Mon, 21 Jan 2019) | 9 lines
      
      [clang-tidy] Use getStripPluginsAdjuster
      
      Summary: See rC351531 for the introduction of getStripPluginsAdjuster.
      
      Reviewers: alexfh
      
      Subscribers: xazax.hun, cfe-commits
      
      Differential Revision: https://reviews.llvm.org/D56902
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351962
      f669262c
    • Hans Wennborg's avatar
      Merging r351531: · d0fae09c
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351531 | kadircet | 2019-01-18 10:00:31 +0100 (Fri, 18 Jan 2019) | 11 lines
      
      [tooling] Add a new argument adjuster for deleting plugin related command line args
      
      Summary:
      Currently both clangd and clang-tidy makes use of this mechanism so
      putting it into tooling so that all tools can make use of it.
      
      Reviewers: ilya-biryukov, sammccall
      
      Subscribers: ioeric, cfe-commits
      
      Differential Revision: https://reviews.llvm.org/D56856
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351961
      d0fae09c
  2. 22 Jan, 2019 8 commits
    • Martin Storsjo's avatar
      1e7e3996
    • Martin Storsjo's avatar
      78ecdd7a
    • Martin Storsjo's avatar
    • Hans Wennborg's avatar
      Merging r351788: · 642a1732
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351788 | kadircet | 2019-01-22 10:10:20 +0100 (Tue, 22 Jan 2019) | 15 lines
      
      [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.
      
      Summary:
      Some projects make use of clang plugins when building, but clangd is
      not aware of those plugins therefore can't work with the same compile command
      arguments.
      
      There were multiple places clangd performed commandline manipulations,
       this one also moves them all into OverlayCDB.
      
      Reviewers: ilya-biryukov
      
      Subscribers: klimek, sammccall, ioeric, MaskRay, jkorous, arphaman, cfe-commits
      
      Differential Revision: https://reviews.llvm.org/D56841
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351860
      642a1732
    • Hans Wennborg's avatar
      Merging r351754: · ee231d02
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351754 | spatel | 2019-01-21 18:46:35 +0100 (Mon, 21 Jan 2019) | 6 lines
      
      [AArch64] add more tests for buildvec to shuffle transform; NFC
      
      These are copied from the sibling x86 file. I'm not sure which
      of the current outputs (if any) is considered optimal, but
      someone more familiar with AArch may want to take a look.
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351858
      ee231d02
    • Hans Wennborg's avatar
      Merging r351753: · 2bebfebe
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351753 | spatel | 2019-01-21 18:30:14 +0100 (Mon, 21 Jan 2019) | 8 lines
      
      [DAGCombiner] fix crash when converting build vector to shuffle
      
      The regression test is reduced from the example shown in D56281.
      This does raise a question as noted in the test file: do we want
      to handle this pattern? I don't have a motivating example for
      that on x86 yet, but it seems like we could have that pattern 
      there too, so we could avoid the back-and-forth using a shuffle.
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351857
      2bebfebe
    • Hans Wennborg's avatar
      Merging r351686: · eb74b596
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351686 | vmiklos | 2019-01-20 15:28:27 +0100 (Sun, 20 Jan 2019) | 5 lines
      
      [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods
      
      Otherwise we don't warn on a struct containing a single public int, but
      we warn on a struct containing a single public std::string, which is
      inconsistent.
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351844
      eb74b596
    • Hans Wennborg's avatar
      Merging r351580: · 119d8a51
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351580 | kli | 2019-01-18 20:57:37 +0100 (Fri, 18 Jan 2019) | 4 lines
      
      [OPENMP][DOCS] Release notes/OpenMP support updates, NFC.
      
      Differential Revision: https://reviews.llvm.org/D56733
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351839
      119d8a51
  3. 18 Jan, 2019 7 commits
    • Hans Wennborg's avatar
      Merging r351426: · e264daec
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351426 | d0k | 2019-01-17 11:25:18 +0100 (Thu, 17 Jan 2019) | 1 line
      
      [MC] Remove unused variable
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351543
      e264daec
    • Hans Wennborg's avatar
      Merging r351463, r351466, r351467, and r351468 · 6e751e81
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351463 | eugenezelenko | 2019-01-17 19:31:34 +0100 (Thu, 17 Jan 2019) | 6 lines
      
      [Documentation] Add a chapter about Clang-tidy integrations.
      
      Patch by Marina Kalashina.
      
      Differential Revision: https://reviews.llvm.org/D54945
      ```
      
      ---------------------------------------------------------------------
      
      ------------------------------------------------------------------------
      r351466 | eugenezelenko | 2019-01-17 20:35:39 +0100 (Thu, 17 Jan 2019) | 2 lines
      
      [Documentation] Fix link in docs/clang-tidy/Contributing.rst.
      
      ------------------------------------------------------------------------
      
      ------------------------------------------------------------------------
      r351467 | eugenezelenko | 2019-01-17 20:47:44 +0100 (Thu, 17 Jan 2019) | 2 lines
      
      [Documentation] Another attempt to fix link in docs/clang-tidy/Contributing.rst. Use HTTPS for links.
      
      ------------------------------------------------------------------------
      
      ------------------------------------------------------------------------
      r351468 | eugenezelenko | 2019-01-17 21:00:23 +0100 (Thu, 17 Jan 2019) | 2 lines
      
      [Documentation] Fix another link in docs/clang-tidy/Contributing.rst.
      
      ------------------------------------------------------------------------
      
      llvm-svn: 351538
      6e751e81
    • Hans Wennborg's avatar
      Merging r351504: · d4d3f779
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351504 | brad | 2019-01-18 02:36:58 +0100 (Fri, 18 Jan 2019) | 2 lines
      
      Use llvm::VersionTuple instead of manual version marshalling
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351536
      d4d3f779
    • Hans Wennborg's avatar
      Merging r351459: · ad1624ff
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351459 | arphaman | 2019-01-17 19:12:45 +0100 (Thu, 17 Jan 2019) | 13 lines
      
      [ObjC] Follow-up r350768 and allow the use of unavailable methods that are
      declared in a parent class from within the @implementation context
      
      This commit extends r350768 and allows the use of methods marked as unavailable
      that are declared in a parent class/category from within the @implementation of
      the class where the method is marked as unavailable.
      This allows users to call init that's marked as unavailable even if they don't
      define it.
      
      rdar://47134898
      
      Differential Revision: https://reviews.llvm.org/D56816
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351535
      ad1624ff
    • Hans Wennborg's avatar
      Merging r351457: · c4fa34c3
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351457 | vlad.tsyrklevich | 2019-01-17 18:53:45 +0100 (Thu, 17 Jan 2019) | 15 lines
      
      TLS: Respect visibility for thread_local variables on Darwin (PR40327)
      
      Summary:
      Teach clang to mark thread wrappers for thread_local variables with
      hidden visibility when the original variable is marked with hidden
      visibility. This is necessary on Darwin which exposes the thread wrapper
      instead of the thread variable. The thread wrapper would previously
      always be created with default visibility unless it had
      linkonce*/weak_odr linkage.
      
      Reviewers: rjmccall
      
      Reviewed By: rjmccall
      
      Differential Revision: https://reviews.llvm.org/D56818
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351533
      c4fa34c3
    • Hans Wennborg's avatar
      Merging r351325: · 47149c4d
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351325 | gbuella | 2019-01-16 13:06:17 +0100 (Wed, 16 Jan 2019) | 26 lines
      
      Assertion in isAllocaPromotable due to extra bitcast goes into lifetime marker
      
      For the given test SROA detects possible replacement and creates a correct alloca. After that SROA is adding lifetime markers for this new alloca. The function getNewAllocaSlicePtr is trying to deduce the pointer type based on the original alloca, which is split, to use it later in lifetime intrinsic.
      
      For the test we ended up with such code (rA is initial alloca [10 x float], which is split, and rA.sroa.0.0 is a new split allocation)
      
      ```
      %rA.sroa.0.0.rA.sroa_cast = bitcast i32* %rA.sroa.0 to [10 x float]*    <----- this one causing the assertion and is an extra bitcast
      %5 = bitcast [10 x float]* %rA.sroa.0.0.rA.sroa_cast to i8*
      call void @llvm.lifetime.start.p0i8(i64 4, i8* %5)
      ```
      
      isAllocaPromotable code assumes that a user of alloca may go into lifetime marker through bitcast but it must be the only one bitcast to i8* type. In the test it's not a i8* type, return false and throw the assertion.
      
      As we are creating a pointer, which will be used in lifetime markers only, the proposed fix is to create a bitcast to i8* immediately to avoid extra bitcast creation.
      
      The test is a greatly simplified to just reproduce the assertion.
      
      Author: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
      
      Reviewers: chandlerc, craig.topper
      
      Reviewed By: chandlerc
      
      Differential Revision: https://reviews.llvm.org/D55934
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351532
      47149c4d
    • Hans Wennborg's avatar
      Merging r351475: · 8593d606
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351475 | rnk | 2019-01-17 21:46:53 +0100 (Thu, 17 Jan 2019) | 16 lines
      
      [InstCombine] Don't sink dynamic allocas
      
      Summary:
      InstCombine's sinking algorithm only thinks about memory. It doesn't
      think about non-memory constraints like stack object lifetime. It can
      sink dynamic allocas across a stacksave call, which may be used with
      stackrestore, which can incorrectly reduce the lifetime of the dynamic
      alloca.
      
      Fixes PR40365
      
      Reviewers: hfinkel, efriedma
      
      Subscribers: hiraditya, llvm-commits
      
      Differential Revision: https://reviews.llvm.org/D56872
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351530
      8593d606
  4. 17 Jan, 2019 13 commits
    • Hans Wennborg's avatar
      Merging r351421: · 2f1402b6
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351421 | ssijaric | 2019-01-17 10:45:17 +0100 (Thu, 17 Jan 2019) | 12 lines
      
      [ARM64][Windows] Share unwind codes between epilogues
      
      There are cases where we have multiple epilogues that have the exact same unwind
      code sequence.  In that case, the epilogues can share the same unwind codes in
      the .xdata section.  This should get us past the assert "SEH unwind data
      splitting not yet implemented" in many cases.
      
      We still need to add support for generating multiple .pdata/.xdata sections for
      those functions that need to be split into fragments.
      
      Differential Revision: https://reviews.llvm.org/D56813
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351452
      2f1402b6
    • Hans Wennborg's avatar
      Merging r351370: · 3553f3e0
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351370 | mgrang | 2019-01-16 20:52:59 +0100 (Wed, 16 Jan 2019) | 14 lines
      
      [COFF, ARM64] Implement support for SEH extensions __try/__except/__finally
      
      Summary:
      This patch supports MS SEH extensions __try/__except/__finally. The intrinsics localescape and localrecover are responsible for communicating escaped static allocas from the try block to the handler.
      
      We need to preserve frame pointers for SEH. So we create a new function/property HasLocalEscape.
      
      Reviewers: rnk, compnerd, mstorsjo, TomTan, efriedma, ssijaric
      
      Reviewed By: rnk, efriedma
      
      Subscribers: smeenai, jrmuizel, alex, majnemer, ssijaric, ehsan, dmajor, kristina, javed.absar, kristof.beyls, chrib, llvm-commits
      
      Differential Revision: https://reviews.llvm.org/D53540
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351451
      3553f3e0
    • Hans Wennborg's avatar
      Merging r351335: · 961b84b2
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351335 | psmith | 2019-01-16 14:24:02 +0100 (Wed, 16 Jan 2019) | 17 lines
      
      [ELF][AArch64] Add R_AARCH64_PLT_PAGE_PC to isRelExpr
      
      As a follow on to D56666 (r351186) there is a case when taking the address
      of an ifunc when linking -pie that can generate a spurious can't create
      dynamic relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol in readonly
      segment. Specifically the case is where the ifunc is in the same
      translation unit as the address taker, so given -fpie the compiler knows
      the ifunc is defined in the executable so it can use a non-got-generating
      relocation.
      
      The error message is due to R_AARCH64_PLT_PAGE_PC not being added to
      isRelExpr, its non PLT equivalent R_AARCH64_PAGE_PC is already in
      isRelExpr.
      
      Differential Revision: https://reviews.llvm.org/D56724
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351446
      961b84b2
    • Hans Wennborg's avatar
      Merging r351326: · 37174c6e
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351326 | psmith | 2019-01-16 13:09:13 +0100 (Wed, 16 Jan 2019) | 15 lines
      
      [ELF] Implement option to force PIC compatible Thunks
      
      By default LLD will generate position independent Thunks when the --pie or
      --shared option is used. Reference to absolute addresses is permitted in
      other cases. For some embedded systems position independent thunks are
      needed for code that executes before the MMU has been set up. The option
      --pic-veneer is used by ld.bfd to force position independent thunks.
          
      The patch adds --pic-veneer as the option is needed for the Linux kernel
      on Arm.
          
      fixes pr39886
          
      Differential Revision: https://reviews.llvm.org/D55505
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351445
      37174c6e
    • Hans Wennborg's avatar
      Merging r351381: · 6f533811
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351381 | ctopper | 2019-01-16 22:46:32 +0100 (Wed, 16 Jan 2019) | 11 lines
      
      [X86] Add X86ISD::VSHLV and X86ISD::VSRLV nodes for psllv and psrlv
      
      Previously we used ISD::SHL and ISD::SRL to represent these in SelectionDAG. ISD::SHL/SRL interpret an out of range shift amount as undefined behavior and will constant fold to undef. While the intrinsics are defined to return 0 for out of range shift amounts. A previous patch added a special node for VPSRAV to produce all sign bits.
      
      This was previously believed safe because undefs frequently get turned into 0 either from the constant pool or a desire to not have a false register dependency. But undef is treated specially in some optimizations. For example, its ignored in detection of vector splats. So if the ISD::SHL/SRL can be constant folded and all of the elements with in bounds shift amounts are the same, we might fold it to single element broadcast from the constant pool. This would not put 0s in the elements with out of bounds shift amounts.
      
      We do have an existing InstCombine optimization to use shl/lshr when the shift amounts are all constant and in bounds. That should prevent some loss of constant folding from this change.
      
      Patch by zhutianyang and Craig Topper
      
      Differential Revision: https://reviews.llvm.org/D56695
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351444
      6f533811
    • Hans Wennborg's avatar
      Merging r351351: · f308f983
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351351 | mareko | 2019-01-16 16:43:53 +0100 (Wed, 16 Jan 2019) | 7 lines
      
      AMDGPU: Add llvm.amdgcn.ds.ordered.add & swap
      
      Reviewers: arsenm, nhaehnle
      
      Subscribers: kzhuravl, jvesely, wdng, yaxunl, dstuttard, tpr, t-tye, llvm-commits
      
      Differential Revision: https://reviews.llvm.org/D52944
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351443
      f308f983
    • Hans Wennborg's avatar
      Merging r351345: · edcbea97
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351345 | asl | 2019-01-16 15:03:41 +0100 (Wed, 16 Jan 2019) | 23 lines
      
      [MSP430] Emit a separate section for every interrupt vector
      
      This is LLVM part of D56663
      
      Linker scripts shipped by TI require to have every
      interrupt vector in a separate section with a specific name:
      
       SECTIONS
       {
         __interrupt_vector_XX   : { KEEP (*(__interrupt_vector_XX )) } > VECTXX
         ...
       }
      
      Follow the requirement emit the section for every vector
      which contain address of interrupt handler:
      
        .section  __interrupt_vector_XX,"ax",@progbits
        .word %isr%
      
      Patch by Kristina Bessonova!
      
      Differential Revision: https://reviews.llvm.org/D56664
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351442
      edcbea97
    • Hans Wennborg's avatar
      Merging r351344: · ec0bc4cc
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351344 | asl | 2019-01-16 14:44:01 +0100 (Wed, 16 Jan 2019) | 10 lines
      
      [MSP430] Improve support of 'interrupt' attribute
      
      * Accept as an argument constants in range 0..63 (aligned with TI headers and linker scripts provided with TI GCC toolchain).
      * Emit function attribute 'interrupt'='xx' instead of aliases (used in the backend to create a section for particular interrupt vector).
      * Add more diagnostics.
      
      Patch by Kristina Bessonova!
      
      Differential Revision: https://reviews.llvm.org/D56663
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351441
      ec0bc4cc
    • Hans Wennborg's avatar
      Merging r351349: · 2b727e7e
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351349 | abataev | 2019-01-16 16:39:52 +0100 (Wed, 16 Jan 2019) | 14 lines
      
      [SLP] Fix PR40310: The reduction nodes should stay scalar.
      
      Summary:
      Sometimes the SLP vectorizer tries to vectorize the horizontal reduction
      nodes during regular vectorization. This may happen inside of the loops,
      when there are some vectorizable PHIs. Patch fixes this by checking if
      the node is the reduction node and thus it must not be vectorized, it must
      be gathered.
      
      Reviewers: RKSimon, spatel, hfinkel, fedor.sergeev
      
      Subscribers: llvm-commits
      
      Differential Revision: https://reviews.llvm.org/D56783
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351440
      2b727e7e
    • Hans Wennborg's avatar
      Merging r351436: · 9d7c2706
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351436 | hans | 2019-01-17 14:11:15 +0100 (Thu, 17 Jan 2019) | 1 line
      
      build_llvm_package.bat: Run more tests
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351437
      9d7c2706
    • Hans Wennborg's avatar
      Merging r351431: · 66303bc3
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351431 | hans | 2019-01-17 12:31:03 +0100 (Thu, 17 Jan 2019) | 19 lines
      
      Revert r351311 "[OMPT] Make sure that OMPT is enabled when accessing internals of the runtime"
      
      and also the follow-up r351315.
      
      The new test is failing on the buildbots.
      
      > Make sure that OMPT is enabled in runtime entry points that access internals
      > of the runtime. Else, return an appropiate value indicating an error or that
      > the data is not available.
      >
      > Patch provided by @sconvent
      >
      > Reviewers: jlpeyton, omalyshe, hbae, Hahnfeld, joachim.protze
      >
      > Reviewed By: joachim.protze
      >
      > Tags: #openmp, #ompt
      >
      > Differential Revision: https://reviews.llvm.org/D47717
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351432
      66303bc3
    • Hans Wennborg's avatar
      Merging r351340: · bcabeb42
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351340 | asl | 2019-01-16 14:28:30 +0100 (Wed, 16 Jan 2019) | 7 lines
      
      [MSP430] Fix msp430-toolchain.c on Windows (added in r351228)
      
      Patch by Kristina Bessonova!
      
      Differential Revision: https://reviews.llvm.org/D56776
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351420
      bcabeb42
    • Hans Wennborg's avatar
      Merging r351360: · cfa62417
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351360 | jmorse | 2019-01-16 18:41:29 +0100 (Wed, 16 Jan 2019) | 6 lines
      
      Add a REQUIRES: darwin line for a mac test.
      
      This test, apparently for macs, fails on Windows as lit can't emulate
      the shell subprocess $(which...) correctly. Some other netbsd and linux
      buildbots also fail here. Limit to macs as a temporary workaround.
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351419
      cfa62417
  5. 16 Jan, 2019 7 commits
    • Rui Ueyama's avatar
      Merging r351396: · 18f9ceeb
      Rui Ueyama authored
      ```---------------------------------------------------------------------
      r351396 | lekensteyn | 2019-01-16 15:28:51 -0800 (Wed, 16 Jan 2019) | 17 lines
      
      [ELF][X86_64] Fix corrupted LD -> LE optimization for TLS without PLT
      
      The LD -> LE optimization for Thread-Local Storage without PLT requires
      an additional "66" prefix, otherwise the next instruction will be
      corrupted, causing runtime misbehavior (crashes) of the linked object.
      
      The other (GD -> IE/LD) optimizations are the same with or without PLT,
      but add tests for completeness. The instructions are copied from
      https://raw.githubusercontent.com/wiki/hjl-tools/x86-psABI/x86-64-psABI-1.0.pdf#subsection.11.1.2
      
      This does not try to address ILP32 (x32) support.
      
      Fixes https://bugs.llvm.org/show_bug.cgi?id=37303
      
      Reviewed By: ruiu
      
      Differential Revision: https://reviews.llvm.org/D56779
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351401
      18f9ceeb
    • Hans Wennborg's avatar
      Merging r351334: · dfde0c76
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351334 | ibiryukov | 2019-01-16 14:18:59 +0100 (Wed, 16 Jan 2019) | 8 lines
      
      Set '-target' flag in the test checking the MacOS include dir
      
      To fix a buildbot failure on PS4, see
      http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/42251
      
      The test was added in r351222 and aims to check only a particular
      Mac configuration. However it relied on the default compiler target
      by default, therefore unintentionally failing on PS4.
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351343
      dfde0c76
    • Hans Wennborg's avatar
      Merging r351327: · 0fbd2b5f
      Hans Wennborg authored
      ```---------------------------------------------------------------------
      r351327 | labath | 2019-01-16 13:19:22 +0100 (Wed, 16 Jan 2019) | 4 lines
      
      Revert "Simplify Value::GetValueByteSize()"
      
      This reverts commit r351250 because it breaks the
      SymbolFile/NativePDB/function-types-builtins.cpp.
      ```
      
      ---------------------------------------------------------------------
      
      llvm-svn: 351342
      0fbd2b5f
    • Hans Wennborg's avatar
      Drop svn version suffix · ebec3ced
      Hans Wennborg authored
      llvm-svn: 351339
      ebec3ced
    • Hans Wennborg's avatar
      Drop svn version suffix · 193ab2b8
      Hans Wennborg authored
      llvm-svn: 351338
      193ab2b8
    • Hans Wennborg's avatar
      Drop svn version suffix · d1f4296d
      Hans Wennborg authored
      llvm-svn: 351337
      d1f4296d
    • Hans Wennborg's avatar
      Drop svn version suffix · c6a3c013
      Hans Wennborg authored
      llvm-svn: 351336
      c6a3c013