and though bugs are the bane of my existence, rest assured the wretched thing will get the best of care here

  1. 20 Dec, 2012 27 commits
  2. 19 Dec, 2012 4 commits
  3. 18 Dec, 2012 1 commit
  4. 17 Dec, 2012 1 commit
  5. 16 Dec, 2012 1 commit
  6. 14 Dec, 2012 3 commits
  7. 13 Dec, 2012 2 commits
  8. 10 Dec, 2012 1 commit
    • Pawel Wodnicki's avatar
      Merging r169719: into 3.2 release branch. · 1816b26c
      Pawel Wodnicki authored
      Fix PR14548: SROA was crashing on a mixture of i1 and i8 loads and stores.
      
      When SROA was evaluating a mixture of i1 and i8 loads and stores, in
      just a particular case, it would tickle a latent bug where we compared
      bits to bytes rather than bits to bits. As a consequence of the latent
      bug, we would allow integers through which were not byte-size multiples,
      a situation the later rewriting code was never intended to handle.
      
      In release builds this could trigger all manner of oddities, but the
      reported issue in PR14548 was forming invalid bitcast instructions.
      
      The only downside of this fix is that it makes it more clear that SROA
      in its current form is not capable of handling mixed i1 and i8 loads and
      stores. Sometimes with the previous code this would work by luck, but
      usually it would crash, so I'm not terribly worried. I'll watch the LNT
      numbers just to be sure.
      
      llvm-svn: 169735
      1816b26c