Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
S
server
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 23
    • Issues 23
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1
    • Merge Requests 1
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

and though bugs are the bane of my existence, rest assured the wretched thing will get the best of care here

  • Confidential and Proprietary
  • NYNJA
  • server
  • Merge Requests
  • !422

Merged
Opened May 12, 2020 by delete2@delete2Contributor

History limit and read notification overhaul

  • Overview 2
  • Commits 19
  • Changes 5

Created by: UlfNorell

  • History limit was pretty much broken, fixed now.

  • Changes representation of #Room.readers. Previously kept a (at most) two element list of last member to write and member who has read the furthest. Now we just keep track of the last message marked as read.

    What we send back to the client on a Room/get request has not changed, but the exact circumstances in which a read notification is sent out has changed slightly. The new behaviour is: when someone marks a message as read, you get a notification if this message (or a later one) hasn't already been marked. The previous behaviour cannot be described in the space of this comment field.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: exconfidential/nynja/server!422
Source branch: history-limit-overhaul