From 82b0d0476159dcaa7d19f18bbc02930b2d380b54 Mon Sep 17 00:00:00 2001 From: sergeyPensov Date: Thu, 18 Oct 2018 16:16:58 +0300 Subject: [PATCH 1/5] add invalid uuid error message --- account-service/1.0/account.proto | 1 + 1 file changed, 1 insertion(+) diff --git a/account-service/1.0/account.proto b/account-service/1.0/account.proto index 46044ca..4054f42 100644 --- a/account-service/1.0/account.proto +++ b/account-service/1.0/account.proto @@ -242,6 +242,7 @@ message ErrorResponse { PROFILE_NOT_FOUND = 25; INVALID_PROFILE_ID = 26; AUTH_PROVIDER_ALREADY_USED = 27; + INVALID_UUID = 28 } Cause cause = 1; string message = 2; -- GitLab From 5781842881cf1e486e00d914809bff8df7e38685 Mon Sep 17 00:00:00 2001 From: sergeyPensov Date: Fri, 19 Oct 2018 14:51:25 +0300 Subject: [PATCH 2/5] add invalid uuid for account error message --- account-service/1.0/account.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/account-service/1.0/account.proto b/account-service/1.0/account.proto index 4054f42..64c4665 100644 --- a/account-service/1.0/account.proto +++ b/account-service/1.0/account.proto @@ -242,7 +242,7 @@ message ErrorResponse { PROFILE_NOT_FOUND = 25; INVALID_PROFILE_ID = 26; AUTH_PROVIDER_ALREADY_USED = 27; - INVALID_UUID = 28 + INVALID_ACCOUNT_ID = 28; } Cause cause = 1; string message = 2; -- GitLab From 5153742cbc9ea9cc783546da492c7446a6940b55 Mon Sep 17 00:00:00 2001 From: sergeyPensov Date: Fri, 19 Oct 2018 15:05:45 +0300 Subject: [PATCH 3/5] Fix mistake with account response --- account-service/1.0/account.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/account-service/1.0/account.proto b/account-service/1.0/account.proto index 64c4665..768d24c 100644 --- a/account-service/1.0/account.proto +++ b/account-service/1.0/account.proto @@ -17,7 +17,7 @@ service AccountService { rpc completePendingAccountCreation(CompletePendingAccountCreationRequest) returns (AccountResponse); rpc createAccount(CreateAccountRequest) returns (AccountResponse); rpc getAllAccountsByProfileId(AccountsByProfileIdRequest) returns (AccountsResponse); - rpc getAccountByAccountId(AccountByAccountIdRequest) returns (AccountsResponse); + rpc getAccountByAccountId(AccountByAccountIdRequest) returns (AccountResponse); rpc getAccountByAuthenticationProvider(AccountByAuthenticationProviderRequest) returns (AccountResponse); rpc updateAccount (UpdateAccountRequest) returns (AccountResponse); rpc updateProfile (UpdateProfileRequest) returns (ProfileResponse); -- GitLab From aa804d429f9a7e500fd6b8d31e189e766c937b72 Mon Sep 17 00:00:00 2001 From: Stanimir Penkov Date: Fri, 12 Oct 2018 12:51:40 +0300 Subject: [PATCH 4/5] NY-3808: Endpoint for adding contact info to account Signed-off-by: Stanimir Penkov --- account-service/1.0/account.proto | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/account-service/1.0/account.proto b/account-service/1.0/account.proto index 768d24c..4e6ca35 100644 --- a/account-service/1.0/account.proto +++ b/account-service/1.0/account.proto @@ -25,6 +25,7 @@ service AccountService { rpc deleteProfile (DeleteProfileRequest) returns (StatusResponse); rpc addAuthenticationProviderToProfile(AddAuthenticationProviderRequest) returns (StatusResponse); rpc deleteAuthenticationProviderFromProfile(DeleteAuthenticationProviderRequest) returns (StatusResponse); + rpc addContactInfoToAccount(AddContactInfoRequest) returns (StatusResponse); } enum AuthenticationType { @@ -115,6 +116,11 @@ message AddAuthenticationProviderRequest { AuthProviderDetails authenticationProvider = 2; } +message AddContactInfoRequest { + string accountId = 1; + ContactDetails contactInfo = 2; +} + message DeleteAuthenticationProviderRequest { string profileId = 1; AuthProviderDetails authenticationProvider = 2; @@ -242,7 +248,9 @@ message ErrorResponse { PROFILE_NOT_FOUND = 25; INVALID_PROFILE_ID = 26; AUTH_PROVIDER_ALREADY_USED = 27; - INVALID_ACCOUNT_ID = 28; + MISSING_CONTACT_INFO_TYPE = 28; + MISSING_CONTACT_INFO_IDENTIFIER = 29; + INVALID_ACCOUNT_ID = 30; } Cause cause = 1; string message = 2; -- GitLab From e37d60ae6e43529517e115ca110c2633c85d9a1c Mon Sep 17 00:00:00 2001 From: Stanimir Penkov Date: Tue, 16 Oct 2018 15:20:55 +0300 Subject: [PATCH 5/5] NY-3808: Added a separate cause for error adding contact info Signed-off-by: Stanimir Penkov --- account-service/1.0/account.proto | 1 + 1 file changed, 1 insertion(+) diff --git a/account-service/1.0/account.proto b/account-service/1.0/account.proto index 4e6ca35..acadcc3 100644 --- a/account-service/1.0/account.proto +++ b/account-service/1.0/account.proto @@ -251,6 +251,7 @@ message ErrorResponse { MISSING_CONTACT_INFO_TYPE = 28; MISSING_CONTACT_INFO_IDENTIFIER = 29; INVALID_ACCOUNT_ID = 30; + ERROR_ADDING_CONTACT_INFO = 31; } Cause cause = 1; string message = 2; -- GitLab