From be0a20a0854035cda5721cbe96d5a363d138d3f6 Mon Sep 17 00:00:00 2001 From: Stoyan Tzenkov Date: Tue, 13 Nov 2018 14:32:21 +0200 Subject: [PATCH] NY-5306: Verification added for auth providers not part of this profile Signed-off-by: Stoyan Tzenkov --- .../biz/nynja/account/services/AccountServiceImpl.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/main/java/biz/nynja/account/services/AccountServiceImpl.java b/src/main/java/biz/nynja/account/services/AccountServiceImpl.java index b9fdf4a..d2c1267 100644 --- a/src/main/java/biz/nynja/account/services/AccountServiceImpl.java +++ b/src/main/java/biz/nynja/account/services/AccountServiceImpl.java @@ -690,7 +690,13 @@ public class AccountServiceImpl extends AccountServiceGrpc.AccountServiceImplBas AuthenticationProvider authenticationProviderToDelete = AuthenticationProvider .createAuthenticationProviderFromProto(request.getAuthenticationProvider()); - profile.removeAuthenticationProvider(authenticationProviderToDelete); + + boolean removedFromObject = profile.removeAuthenticationProvider(authenticationProviderToDelete); + if(!removedFromObject) { + logAndBuildGrpcStatusResponse(responseObserver, StatusResponse.newBuilder(), "Authentication provider {} is not used by this profile.", + authenticationProviderToDelete.toString(), Cause.AUTH_PROVIDER_NOT_FOUND); + return; + } if (profile.getAuthenticationProviders().size() < MIN_NUMBER_OF_AUTH_PROVIDERS_IN_PROFILE) { logger.error( -- GitLab