From 1e4659561a78c49e89614bb9927fdfe6cd9ece7e Mon Sep 17 00:00:00 2001 From: Stoyan Tzenkov Date: Wed, 14 Aug 2019 15:54:25 +0300 Subject: [PATCH 1/3] KAFKA: Set MAX_BLOCK_MS to 1 second to avoid looping if Kafka service is down. Signed-off-by: Stoyan Tzenkov --- .../java/biz/nynja/account/kafka/KafkaProducerConfig.java | 7 +++++++ src/main/resources/application-dev.yml | 2 ++ 2 files changed, 9 insertions(+) diff --git a/src/main/java/biz/nynja/account/kafka/KafkaProducerConfig.java b/src/main/java/biz/nynja/account/kafka/KafkaProducerConfig.java index b9f2ebc..a67eae7 100644 --- a/src/main/java/biz/nynja/account/kafka/KafkaProducerConfig.java +++ b/src/main/java/biz/nynja/account/kafka/KafkaProducerConfig.java @@ -25,6 +25,10 @@ public class KafkaProducerConfig { private String KAFKA_PORT; @Value("${kafka.topic}") private String KAFKA_TOPIC; + @Value("${kafka.max.block.ms}") + private String KAFKA_MAX_BLOCK_MS; + @Value("${kafka.reconnect.backoff.ms}") + private String KAFKA_RECONNECT_BACKOFF_MS; @Bean(name = "kafkaTopic") public String kafkaTopic() { @@ -42,6 +46,9 @@ public class KafkaProducerConfig { configProps.put(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG, StringSerializer.class); configProps.put(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG, JsonSerializer.class); + configProps.put(ProducerConfig.RECONNECT_BACKOFF_MS_CONFIG, KAFKA_RECONNECT_BACKOFF_MS); // The base amount of time to wait before attempting to reconnect to a given host. default=50L + configProps.put(ProducerConfig.MAX_BLOCK_MS_CONFIG, KAFKA_MAX_BLOCK_MS); + return new DefaultKafkaProducerFactory(configProps); } diff --git a/src/main/resources/application-dev.yml b/src/main/resources/application-dev.yml index 879dcba..94c3cdb 100644 --- a/src/main/resources/application-dev.yml +++ b/src/main/resources/application-dev.yml @@ -47,6 +47,8 @@ kafka: host: 127.0.0.1 port: 9092 topic: userEventss + max.block.ms: 1000 + reconnect.backoff.ms: 10000 #Metrics related configurations management: -- GitLab From e7c5f7ee90542b92ba87c47dd9b30313aea5d45d Mon Sep 17 00:00:00 2001 From: Stoyan Tzenkov Date: Wed, 14 Aug 2019 16:55:39 +0300 Subject: [PATCH 2/3] KAFKA: Updated application-production.yml Signed-off-by: Stoyan Tzenkov --- src/main/resources/application-production.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main/resources/application-production.yml b/src/main/resources/application-production.yml index f97fa40..240a1d6 100644 --- a/src/main/resources/application-production.yml +++ b/src/main/resources/application-production.yml @@ -40,6 +40,8 @@ kafka: host: ${KAFKA_HOST:kafka.kafka.svc.cluster.local} port: ${KAFKA_PORT:9092} topic: ${KAFKA_TOPIC:userEvents} + max.block.ms: ${KAFKA_MAX_BLOCK_MS:1000} + reconnect.backoff.ms: ${KAFKA_RECONNECT_BACKOFF_MS:10000} #Metrics related configurations management: -- GitLab From 4a37b67b7e78e7934c9107007bd716eb3cdfab22 Mon Sep 17 00:00:00 2001 From: Angel Botev Date: Thu, 15 Aug 2019 16:35:50 +0300 Subject: [PATCH 3/3] Change names of config values; Signed-off-by: Angel Botev --- .../java/biz/nynja/account/kafka/KafkaProducerConfig.java | 4 ++-- src/main/resources/application-dev.yml | 4 ++-- src/main/resources/application-production.yml | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main/java/biz/nynja/account/kafka/KafkaProducerConfig.java b/src/main/java/biz/nynja/account/kafka/KafkaProducerConfig.java index a67eae7..64d0edd 100644 --- a/src/main/java/biz/nynja/account/kafka/KafkaProducerConfig.java +++ b/src/main/java/biz/nynja/account/kafka/KafkaProducerConfig.java @@ -25,9 +25,9 @@ public class KafkaProducerConfig { private String KAFKA_PORT; @Value("${kafka.topic}") private String KAFKA_TOPIC; - @Value("${kafka.max.block.ms}") + @Value("${kafka.max-block-ms}") private String KAFKA_MAX_BLOCK_MS; - @Value("${kafka.reconnect.backoff.ms}") + @Value("${kafka.reconnect-backoff-ms}") private String KAFKA_RECONNECT_BACKOFF_MS; @Bean(name = "kafkaTopic") diff --git a/src/main/resources/application-dev.yml b/src/main/resources/application-dev.yml index 94c3cdb..b890db9 100644 --- a/src/main/resources/application-dev.yml +++ b/src/main/resources/application-dev.yml @@ -47,8 +47,8 @@ kafka: host: 127.0.0.1 port: 9092 topic: userEventss - max.block.ms: 1000 - reconnect.backoff.ms: 10000 + max-block-ms: 1000 + reconnect-backoff-ms: 10000 #Metrics related configurations management: diff --git a/src/main/resources/application-production.yml b/src/main/resources/application-production.yml index 240a1d6..f832bac 100644 --- a/src/main/resources/application-production.yml +++ b/src/main/resources/application-production.yml @@ -40,8 +40,8 @@ kafka: host: ${KAFKA_HOST:kafka.kafka.svc.cluster.local} port: ${KAFKA_PORT:9092} topic: ${KAFKA_TOPIC:userEvents} - max.block.ms: ${KAFKA_MAX_BLOCK_MS:1000} - reconnect.backoff.ms: ${KAFKA_RECONNECT_BACKOFF_MS:10000} + max-block-ms: ${KAFKA_MAX_BLOCK_MS:700} + reconnect-backoff-ms: ${KAFKA_RECONNECT_BACKOFF_MS:10000} #Metrics related configurations management: -- GitLab