From eef3c20754950851c7a45b1195910618a473d4a5 Mon Sep 17 00:00:00 2001 From: Stoyan Tzenkov Date: Mon, 21 Jan 2019 11:03:11 +0200 Subject: [PATCH] NY-6559: Logging for createPendingAccount corrected. Signed-off-by: Stoyan Tzenkov --- .../nynja/account/services/AccountServiceImpl.java | 12 +++++++++--- .../services/decomposition/AccountCreator.java | 9 ++------- .../biz/nynja/account/validation/Validators.java | 10 +++++++--- 3 files changed, 18 insertions(+), 13 deletions(-) diff --git a/src/main/java/biz/nynja/account/services/AccountServiceImpl.java b/src/main/java/biz/nynja/account/services/AccountServiceImpl.java index 058737b..d33e624 100644 --- a/src/main/java/biz/nynja/account/services/AccountServiceImpl.java +++ b/src/main/java/biz/nynja/account/services/AccountServiceImpl.java @@ -5,6 +5,7 @@ package biz.nynja.account.services; import static biz.nynja.account.validation.Validators.account; import static biz.nynja.account.validation.Validators.authenticationProvider; +import static biz.nynja.account.validation.Validators.pendingAccount; import static biz.nynja.account.validation.Validators.phoneValidator; import static biz.nynja.account.validation.Validators.util; @@ -456,14 +457,19 @@ public class AccountServiceImpl extends AccountServiceGrpc.AccountServiceImplBas @Permitted(role = RoleConstants.USER) public void createPendingAccount(CreatePendingAccountRequest request, StreamObserver responseObserver) { + CreatePendingAccountResponse response; logger.info("Creating pending account..."); logger.debug("Creating pending account: {} ...", request); - CreatePendingAccountResponse response = accountCreator.retrieveCreatePendingAccountResponse(request); + Optional cause = pendingAccount.validateCreatePendingAccountRequest(request); + if (cause.isPresent()) { + response = CreatePendingAccountResponse.newBuilder().setError(ErrorResponse.newBuilder().setCause(cause.get())) + .build(); + } else { + response = accountCreator.retrieveCreatePendingAccountResponse(request); + } - logger.info("SUCCESS: Created pending account for provider {}: \"{}\"", request.getAuthenticationProvider(), - response); responseObserver.onNext(response); responseObserver.onCompleted(); } diff --git a/src/main/java/biz/nynja/account/services/decomposition/AccountCreator.java b/src/main/java/biz/nynja/account/services/decomposition/AccountCreator.java index 9123af3..d8893c4 100644 --- a/src/main/java/biz/nynja/account/services/decomposition/AccountCreator.java +++ b/src/main/java/biz/nynja/account/services/decomposition/AccountCreator.java @@ -55,11 +55,6 @@ public class AccountCreator { * @return */ public CreatePendingAccountResponse retrieveCreatePendingAccountResponse(CreatePendingAccountRequest request) { - Optional cause = pendingAccount.validateCreatePendingAccountRequest(request); - if (cause.isPresent()) { - return CreatePendingAccountResponse.newBuilder().setError(ErrorResponse.newBuilder().setCause(cause.get())) - .build(); - } if (request.getAuthenticationType() == AuthenticationType.PHONE) { // Get the normalized phone number from libphone @@ -98,8 +93,8 @@ public class AccountCreator { logger.debug("Pending account \"{}\" saved into the DB", savedPendingAccount); response = CreatePendingAccountResponse.newBuilder().setPendingAccountDetails(savedPendingAccount.toProto()) .build(); - logger.info("Pending account created successfully."); - logger.debug("Pending account: \"{}\" created successfully.", response); + logger.info("SUCCESS: Pending account created successfully."); + logger.debug("SUCCESS: Pending account: \"{}\" created successfully.", response); return response; } catch (Exception e) { logger.error(e.getMessage()); diff --git a/src/main/java/biz/nynja/account/validation/Validators.java b/src/main/java/biz/nynja/account/validation/Validators.java index 21dc73c..ee89711 100644 --- a/src/main/java/biz/nynja/account/validation/Validators.java +++ b/src/main/java/biz/nynja/account/validation/Validators.java @@ -453,9 +453,13 @@ public class Validators { logger.info("Checking email: {}", email); EmailValidator eValidator = EmailValidator.getInstance(); - boolean result = eValidator.isValid(email); - logger.info("Email: {} is " + (result ? "" : "not ") + "valid.", email); - return result; + boolean validated = eValidator.isValid(email); + if (!validated) { + logger.error("Email: {} is not valid.", email); + } else { + logger.info("Email: {} is valid.", email); + } + return validated; } public boolean validateBirthdayIsSet(Date birthday) { -- GitLab