From b858e02d92e3c7e75803f1555e1a7674b02cc856 Mon Sep 17 00:00:00 2001 From: Ergyun Syuleyman Date: Tue, 5 May 2020 17:58:28 +0300 Subject: [PATCH] -crash fixes: * ConferenceSDKModule.java line 2722 com.nynja.mobile.communicator.data.sdk.calls.ConferenceSDKModule.startIncommingConferenceActivity * ConferenceSDKModule.java line 1576 com.nynja.mobile.communicator.data.sdk.calls.ConferenceSDKModule.lambda$replaceNewCal * ConferenceSDKModule.java line 1076 com.nynja.mobile.communicator.data.sdk.calls.ConferenceSDKModule.onConferenceMembersS --- .../data/sdk/calls/ConferenceSDKModule.java | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/app/src/main/java/com/nynja/mobile/communicator/data/sdk/calls/ConferenceSDKModule.java b/app/src/main/java/com/nynja/mobile/communicator/data/sdk/calls/ConferenceSDKModule.java index b00746dd83..37f48ba5fb 100644 --- a/app/src/main/java/com/nynja/mobile/communicator/data/sdk/calls/ConferenceSDKModule.java +++ b/app/src/main/java/com/nynja/mobile/communicator/data/sdk/calls/ConferenceSDKModule.java @@ -1073,9 +1073,7 @@ public class ConferenceSDKModule extends BaseSDKModule { if (!hasCreatedActiveCall()) return; Timber.d("Request conference member with \'ConferenceId\'=\'" + conferenceId + "\' " + (result ? "succeed" : "failed!!!")); - synchronized (mActiveConference.mData) { - mActiveConference.mData.mParticipantArray = mActiveConference.mConference.getParticipants(); - } + mActiveConference.mData.mParticipantArray = mActiveConference.mConference.getParticipants(); // update chatRoomId if (mActiveConference.mData.mParticipantArray != null && @@ -1564,6 +1562,14 @@ public class ConferenceSDKModule extends BaseSDKModule { mBillingManager.setListener(mBillingManagerListener); } + private synchronized void startReplacedNewCall() { + if (hasCreatedActiveCall()) { + mActiveConference.isCallInProgress = true; + mActiveConference.mData.mParticipantArray = mActiveConference.mConference.getParticipants(); + startConferenceActivityImpl(NynjaNavigator.MAIN_NEW_CALL, true); + } + } + private void replaceNewCall(String callId) { NYNCall call = mCallManager.getCallById(callId); if (call != null) { @@ -1572,11 +1578,7 @@ public class ConferenceSDKModule extends BaseSDKModule { if (hasCreatedActiveCall()) { initConferenceCall(false); new Handler(Looper.getMainLooper()).postDelayed(() -> { - mActiveConference.isCallInProgress = true; - synchronized (mActiveConference.mData) { - mActiveConference.mData.mParticipantArray = mActiveConference.mConference.getParticipants(); - } - startConferenceActivityImpl(NynjaNavigator.MAIN_NEW_CALL, true); + startReplacedNewCall(); }, Consts.DELAY_100); } } @@ -2784,7 +2786,7 @@ public class ConferenceSDKModule extends BaseSDKModule { return true; } else if (!mStateDevice.isDeviceActive()) { // launch the activity since the navigation router is unset (while the app is on background) - Intent newIntent = MainActivity.getLaunchIntent(getContext(), false, screenKey != null); + Intent newIntent = MainActivity.getLaunchIntent(getContext(), false, true); getContext().startActivity(newIntent); return true; } @@ -2991,9 +2993,7 @@ public class ConferenceSDKModule extends BaseSDKModule { } } if (mActiveConference.mData.mParticipantArray.size() > 1 && TEMP_ALLOW_UPDATE_CONF_CALLS_NAME) { - synchronized (mActiveConference.mData) { - mActiveConference.mData.mParticipantArray.remove(index); - } + mActiveConference.mData.mParticipantArray.remove(index); tryUpdateConferenceCallName(mActiveConference, generateGroupConferenceName(mActiveConference.mData.mParticipantArray.size() - 1));// exclude me } -- GitLab