From 967c92529b7eceda4b8885e3936b34da9c7c0f13 Mon Sep 17 00:00:00 2001 From: Conrad S Date: Wed, 1 Feb 2017 16:38:08 -0500 Subject: [PATCH 1/3] Add onClick to whole row --- src/components/BuildingListTable/index.js | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/src/components/BuildingListTable/index.js b/src/components/BuildingListTable/index.js index 45ca7cea..430bbd52 100644 --- a/src/components/BuildingListTable/index.js +++ b/src/components/BuildingListTable/index.js @@ -1,5 +1,5 @@ import React, { PropTypes } from 'react'; -import { Link } from 'react-router'; +import { browserHistory } from 'react-router'; import './styles.scss'; export default function BuildingListTable({ buildings }) { @@ -11,18 +11,16 @@ export default function BuildingListTable({ buildings }) { { item } , ); + /* eslint-disable */ + const handleRowClick = function (building) { + const newPath = `/buildings/${building.building_id.toString()}`; + browserHistory.push(newPath); + }; + const buildingItems = buildings.map(building => ( - - {/* - TODO make entire row a link & make path relative - React router Link component does not support relative paths - */} - - - {building.address} - - + + {building.address} {building.bbl} {building.borough} {building.building_id} -- GitLab From d60c36165054d8efc16994a83c9a30495b8631bf Mon Sep 17 00:00:00 2001 From: Conrad S Date: Wed, 1 Feb 2017 17:06:52 -0500 Subject: [PATCH 2/3] Remove bind and define function with arrows --- src/components/BuildingListTable/index.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/BuildingListTable/index.js b/src/components/BuildingListTable/index.js index 430bbd52..90d5f473 100644 --- a/src/components/BuildingListTable/index.js +++ b/src/components/BuildingListTable/index.js @@ -11,15 +11,15 @@ export default function BuildingListTable({ buildings }) { { item } , ); - /* eslint-disable */ - const handleRowClick = function (building) { + const handleRowClick = (building) => { const newPath = `/buildings/${building.building_id.toString()}`; browserHistory.push(newPath); }; + /* eslint-disable jsx-a11y/no-static-element-interactions */ const buildingItems = buildings.map(building => ( - + handleRowClick(building)}> {building.address} {building.bbl} {building.borough} -- GitLab From 8403f5ebd228f1bf489d150440ce97724641c460 Mon Sep 17 00:00:00 2001 From: Alessandro DiMarco Date: Wed, 1 Feb 2017 17:18:45 -0500 Subject: [PATCH 3/3] Fix long jsx line --- src/components/BuildingListTable/index.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/components/BuildingListTable/index.js b/src/components/BuildingListTable/index.js index 90d5f473..615744f0 100644 --- a/src/components/BuildingListTable/index.js +++ b/src/components/BuildingListTable/index.js @@ -16,10 +16,14 @@ export default function BuildingListTable({ buildings }) { browserHistory.push(newPath); }; - /* eslint-disable jsx-a11y/no-static-element-interactions */ + /* eslint-disable jsx-a11y/no-static-element-interactions */ const buildingItems = buildings.map(building => ( - handleRowClick(building)}> + handleRowClick(building)} + > {building.address} {building.bbl} {building.borough} -- GitLab