diff --git a/bpeng/tests/test_weather.py b/bpeng/tests/test_weather.py index 63ed9ca2d510933232667a3beb1942e4477814b2..87e04c50a6f733e41646d496d057b10f735da8e2 100644 --- a/bpeng/tests/test_weather.py +++ b/bpeng/tests/test_weather.py @@ -21,8 +21,8 @@ class TestWeather: self.scraper3 = WeatherUnderground( period='period', - startdate='2017/03/11', - enddate='2017/03/12', + startdate='2017/03/07', + enddate='2017/03/10', ) def test_parse(self): @@ -37,3 +37,7 @@ class TestWeather: assert output['humidity'][0] == 51.384615384615387 assert output['wind'][1] == 9.6279999999999983 assert output['rain'][1] == 0.26999999999999996 + + self.scraper3.get_weather(detail=True) + output = self.scraper3.output_daily_data() + print(output) diff --git a/bpeng/weather/weather.py b/bpeng/weather/weather.py index 4a20dfa25bdc62caf858b5ceb8a462bf8b830f2d..4e5ec7b5d4c295bceb8e742074ee88a797b788e1 100644 --- a/bpeng/weather/weather.py +++ b/bpeng/weather/weather.py @@ -109,17 +109,19 @@ class WeatherUnderground: html_lines = html.split('\n')[2:-1] # 2D list where each entry is a list of features for a given timestamp html_features = [line.split(',')[:-1] for line in html_lines] + delete_list = [] # Loop through all of the features, removing ones with invalid temperature for entry in html_features: try: - if float(entry[1]) < self.MIN_ALLOWED_TEMPERATURE: - html_features.remove(entry) + delete_list.append(entry) # pylint: disable=broad-except,unused-variable except Exception as err: - html_features.remove(entry) + delete_list.append(entry) # pylint: enable=broad-except,unused-variable + for entry in delete_list: + html_features.remove(entry) return html_features @staticmethod