Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
B
bpengine
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 3
    • Merge Requests 3
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

and though bugs are the bane of my existence, rest assured the wretched thing will get the best of care here

  • Confidential and Proprietary
  • BlocPower
  • bpengine
  • Merge Requests
  • !37

Merged
Opened Jul 31, 2019 by Tillie Kottmann@deletescapeOwner

Add u_value parameter to idf creation (backwards-compatible)

  • Overview 1
  • Commits 2
  • Changes 1

Created by: john525

This PR adds an extra keyword parameter in the function idf_creation (simulation/base.py). The user can pass u_values='Automatic' or leave the value unspecified and the function will run as usual, or they can pass a dict containing labeled u_values, which are then written to the IDF file in the correct format. (So this code should work with both the old simulation backend, and the modified backend I have been working on.)

The PR also adds some logging to the idf creation base class (written to /var/log/simulation.log within the docker container), so we can easily track down the error that occurs when EnergyPlus and OPlus versions are incompatible, in case that ever happens again (the error message OPlus gives for that particular issue is very vague).

This is a very simple PR, so a manual code review is probably sufficient. (There are about ~20 new lines of code, some of which are log statements.) I've already tested it in my local environment, and everything is working as intended.

To test this PR, do the testing procedure out lined in https://github.com/blocp/development/pull/29

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: exconfidential/blocpower/bpengine!37
Source branch: eplus_fix2