Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
P
PNA
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1
    • Merge Requests 1
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

and though bugs are the bane of my existence, rest assured the wretched thing will get the best of care here

  • Confidential and Proprietary
  • BlocPower
  • PNA
  • Merge Requests
  • !78

Open
Opened Jun 19, 2020 by Tillie Kottmann@deletescapeOwner
  • Report abuse
Report abuse

Bi 1205 return to review page after edit

  • Overview 20
  • Commits 36
  • Changes 31

Created by: Jinal-7

Issues:

  • BI-1205 Return to review page after EDIT (Has child issues)
  • BI-1388 Back Button is not working properly for NYC BIS
  • BI-1428 Continue button is not disabled for multi selection questions when no option is selected as an answer
  • BI-1387 Review page does not display cooling system type in case of Minisplit Heat Pump System
  • BI-1397 If user changes building type from review page, Review page does not change questions accordingly
  • BI-1430 Disable back button when in edit state from review page

Test:

  • Pull from this branch or test on dev
  • Test by playing around with every cities' BIS
  • I think I have covered every edge cases - previous question, next question, edit, minisplit, no heating cooling system etc.
  • If I have missed any edge case(s), do let me know!

Note:

  • This PR is NOT for refactoring codebase.
  • The codebase is longer than previously as there were many small bugs and many edge cases, which had to be covered.
  • There is another branch where I'm working on refactoring currently.
  • Here is the link to add suggestions for refactoring codebase.
  • Feel free to ask any questions regarding logic.
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: exconfidential/blocpower/PNA!78
Source branch: BI-1205-Return-to-review-page-after-EDIT