Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
D
deemix
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 13
    • Issues 13
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 0
    • Merge Requests 0
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

and though bugs are the bane of my existence, rest assured the wretched thing will get the best of care here

  • RemixDev
  • deemix
  • Issues
  • #13

Closed
Open
Opened Nov 24, 2020 by DoNot AskMe@itsamegreenContributor

[FEATURE] custom tagging

Background/Use-Case: I want my synced lyrics to be saved to a tag in FLAC. This hasn't been implemented, because there isn't a standard tag/format for it.

Workaround: I simply edit taggers.py to include my extra tag:

diff --git a/deemix/utils/taggers.py b/deemix/utils/taggers.py
index e764b37..4a8fbe3 100644
--- a/deemix/utils/taggers.py
+++ b/deemix/utils/taggers.py
@@ -182,6 +182,10 @@ def tagFLAC(stream, track, save):
         tag["REPLAYGAIN_TRACK_GAIN"] = track.replayGain
     if track.lyrics['unsync'] and save['lyrics']:
         tag["LYRICS"] = track.lyrics['unsync']
+    if track.lyrics['sync'] and save['syncedLyrics']:
+        # no standard tag
+        tag["LRC"] = track.lyrics['sync']
+
 
     for role in track.contributors:
         if role in ['author', 'engineer', 'mixer', 'producer', 'writer', 'composer']:

Feature request: I want to be able to create custom tags.

Ideas:

  1. Hooking system: Ability to register functions to be called at a specific point in execution. If this could somehow be integrated with the config, it would be possible to use it with pyweb/webui.
  2. User-defined tag mapping in config.
  3. Short way: Just add my change.

What do you think?

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: RemixDev/deemix#13